-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799) #57997
*: avoid unlock of unlocked mutex panic on TableDeltaMap (#57799) #57997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57997 +/- ##
================================================
Coverage ? 56.8813%
================================================
Files ? 1772
Lines ? 626967
Branches ? 0
================================================
Hits ? 356627
Misses ? 246180
Partials ? 24160
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for cherrypick.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57799
What problem does this PR solve?
Issue Number: close #57798
Problem Summary:
What changed and how does it work?
It's most likely that
unlock of unlocked mutex
is caused by the struct assignment that overwrite the mutex field.The old code is weird,tdmLock
is used to protectTableDeltaMap
but it's not goes together withTableDeltaMap
.I wrapTableDeltaMap
into a struct and provideClone()
andVisit()
function to it.Just tiny workaround!
Check List
Tests
Some kind of data race, not easy to check in the unit test way
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.