Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: make table existence check unified on different br client (#58211) #58262

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58211

What problem does this PR solve?

Issue Number: close #58168

Problem Summary:

What changed and how does it work?

Remove the client check of tableExistenceCheck, now it works on both sql and cli client.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
截屏2024-12-12 18 36 48_副本

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 14, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@6ec3d04). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58262   +/-   ##
================================================
  Coverage               ?   56.9077%           
================================================
  Files                  ?       1773           
  Lines                  ?     627048           
  Branches               ?          0           
================================================
  Hits                   ?     356839           
  Misses                 ?     246124           
  Partials               ?      24085           
Flag Coverage Δ
integration 36.8367% <ø> (?)
unit 72.5822% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.3877% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 14, 2024
Copy link

ti-chi-bot bot commented Dec 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2024
Copy link

ti-chi-bot bot commented Dec 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-14 05:07:22.039336329 +0000 UTC m=+674232.128138867: ☑️ agreed by BornChanger.
  • 2024-12-15 03:25:14.009895592 +0000 UTC m=+754504.098698130: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit a4f58fe into pingcap:release-8.5 Dec 15, 2024
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants