-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix the parse problematic slow log panic issue due to empty value string (#58258) #58271
executor: Fix the parse problematic slow log panic issue due to empty value string (#58258) #58271
Conversation
Signed-off-by: yibin <huyibin@pingcap.cn>
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/unhold |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #58271 +/- ##
================================================
Coverage ? 73.6217%
================================================
Files ? 1097
Lines ? 353003
Branches ? 0
================================================
Hits ? 259887
Misses ? 76393
Partials ? 16723 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #58258
What problem does this PR solve?
Issue Number: close #58147
Problem Summary:
Handle uncommon empty value string case in slow log, still not sure why empty copr addr appeared.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.