Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade the PD client to adopt the latest refactor #58440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #58439.

Problem Summary:

Upgrade the PD client to adopt the latest refactor.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 20, 2024
Copy link

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger, lance6716 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. labels Dec 20, 2024
Copy link

tiprow bot commented Dec 20, 2024

@JmPotato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 85d7ad9 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Dec 20, 2024

@JmPotato: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 85d7ad9 link true /test build
pull-integration-e2e-test 85d7ad9 link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/check_dev 85d7ad9 link true /test check-dev
pull-br-integration-test 85d7ad9 link true /test pull-br-integration-test
pull-integration-ddl-test 85d7ad9 link true /test pull-integration-ddl-test
pull-mysql-client-test 85d7ad9 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test 85d7ad9 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 85d7ad9 link true /test check-dev2
pull-lightning-integration-test 85d7ad9 link true /test pull-lightning-integration-test
pull-unit-test-ddlv1 85d7ad9 link true /test pull-unit-test-ddlv1
idc-jenkins-ci-tidb/unit-test 85d7ad9 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dumpling This is related to Dumpling of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant