Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, runtime_filter: Remove redundant logs whose meaning can be directly displayed by default behavior (#57626) #58463

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57626

What problem does this PR solve?

Issue Number: close #57625

Problem Summary:

What changed and how does it work?

Runtime Filter generator is log the warning message when it cannot generator a RF for a hash join. But RF could not support Tidb hash join by default
Since this type of log will be printed in TiDB in large quantities, as long as query is TiDB hash joins, I decided to delete this log directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@f3038bc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #58463   +/-   ##
================================================
  Coverage               ?   72.1774%           
================================================
  Files                  ?       1417           
  Lines                  ?     413707           
  Branches               ?          0           
================================================
  Hits                   ?     298603           
  Misses                 ?      95122           
  Partials               ?      19982           
Flag Coverage Δ
unit 72.1774% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.6048% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2024
Copy link

ti-chi-bot bot commented Dec 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-23 06:24:29.922125027 +0000 UTC m=+1456460.010927562: ☑️ agreed by hawkingrei.
  • 2024-12-26 04:56:20.14378015 +0000 UTC m=+1710370.232582693: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 287f27e into pingcap:release-7.5 Dec 26, 2024
18 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-57626-to-release-7.5 branch December 26, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants