-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Ensure index without stats survives for skyling pruning | tidb-test=pr/2465 (#58729) #59227
base: release-8.5
Are you sure you want to change the base?
planner: Ensure index without stats survives for skyling pruning | tidb-test=pr/2465 (#58729) #59227
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #59227 +/- ##
================================================
Coverage ? 22.7886%
================================================
Files ? 1670
Lines ? 611388
Branches ? 0
================================================
Hits ? 139327
Misses ? 454463
Partials ? 17598
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Original merge error - removed old code
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #58729
What problem does this PR solve?
Issue Number: close #57948
Problem Summary:
What changed and how does it work?
Enhanced CompareCandidates logic within SkyLinePruning to allow an index without statistics to survive so that it can be preferenced above a tablescan if it has more equals predicates than other available choices.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.