Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: improve perf of aggregation which have no group-by item #6210

Merged
merged 1 commit into from
Apr 3, 2018
Merged

executor: improve perf of aggregation which have no group-by item #6210

merged 1 commit into from
Apr 3, 2018

Conversation

winoros
Copy link
Member

@winoros winoros commented Apr 3, 2018 •
edited
Loading

runtime.convT2I costs too much when there's no group-by item.
PTAL @zz-jason @XuHuaiyu

zz-jason
zz-jason reviewed Apr 3, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Apr 3, 2018

Could you post some benchmark result?

@shenli
Copy link
Member

shenli commented Apr 3, 2018

/run-all-tests

@winoros
Copy link
Member Author

winoros commented Apr 3, 2018

For stream aggregation select count(*) from t where the size of t is 3*10^6, its own cost time deduce from 7.5s to 5s. (Note that in test environment, we won't push aggregation down to tikv, just block it.)

XuHuaiyu
XuHuaiyu approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 3, 2018
@winoros winoros merged commit 73c3a82 into pingcap:master Apr 3, 2018
@winoros winoros deleted the agg-convT2I branch April 3, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @shenli @zz-jason @XuHuaiyu @zimulala