executor: remove joinResultGenerator.emit and rename emitToChunk to emit #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Apr 3, 2018
| @@ -35,30 +35,26 @@ var ( | |||
| // joinResultGenerator is used to generate join results according the join type, see every implementor for detailed information. | |||
| type joinResultGenerator interface { | |||
| // emit tries to join an outer row with a batch of inner rows. | |||
| // When len(inners) == 0, it means that the outer row can not be joined with any inner row: | |||
| // When inners == nil or inners.Len() == 0, it means that the outer row can not be joined with any inner row: | |||
There was a problem hiding this comment.
inners == nil is covered by len(inners) == 0
There was a problem hiding this comment.
It's inners.Len, not len(inners).
|
LGTM |
|
/run-all-tests |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
PTAL @zz-jason @winoros