store/mockstore: Fix that DeleteRange didn't encode keys. #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit e2c6be4 Author: MyonKeminta <mk@mkmkm.me> Date: Wed Apr 11 10:04:55 2018 +0800 Fix: delete range in mocktikv didn't encode key commit 88e8477 Merge: ef512dc e2269be Author: MyonKeminta <mk@mkmkm.me> Date: Wed Apr 11 09:16:47 2018 +0800 Merge branch 'master' into misono/mock-tikv-delete-range commit ef512dc Merge: 0a02583 13a7f19 Author: Lynn <zimu_xia@126.com> Date: Mon Apr 9 10:47:29 2018 +0800 Merge branch 'master' into misono/mock-tikv-delete-range commit 0a02583 Merge: 7ec31e8 fbae31e Author: tiancaiamao <tiancaiamao@gmail.com> Date: Sun Apr 8 07:31:45 2018 -0500 Merge branch 'master' into misono/mock-tikv-delete-range commit 7ec31e8 Merge: 9cfc4e5 9e176ea Author: Ewan Chou <coocood@gmail.com> Date: Wed Apr 4 22:24:35 2018 +0800 Merge branch 'master' into misono/mock-tikv-delete-range commit 9cfc4e5 Author: MyonKeminta <mk@mkmkm.me> Date: Wed Apr 4 00:24:18 2018 +0800 Fix ts commit e5da638 Author: MyonKeminta <mk@mkmkm.me> Date: Wed Apr 4 00:15:59 2018 +0800 Add test commit 1af5aea Author: MyonKeminta <mk@mkmkm.me> Date: Tue Apr 3 22:23:20 2018 +0800 Implement delete range in mvcc leveldb commit bc1d6a1 Merge: c97fb30 ccf6da1 Author: MyonKeminta <mk@mkmkm.me> Date: Tue Apr 3 21:44:49 2018 +0800 Merge branch 'master' into misono/mock-tikv-delete-range commit c97fb30 Merge: f408426 c86cd59 Author: zhangjinpeng1987 <zhangjinpeng@pingcap.com> Date: Wed Mar 28 11:01:06 2018 +0800 Merge branch 'master' into misono/mock-tikv-delete-range commit f408426 Author: MyonKeminta <mk@mkmkm.me> Date: Mon Mar 26 15:00:01 2018 +0800 store/mockstore: Add deleterange to mock tikv
|
@tiancaiamao PTAL |
zimulala
reviewed
Apr 12, 2018
| } | ||
|
|
||
| return mvcc.db.Write(batch, nil) | ||
| return mvcc.doRawDeleteRange(codec.EncodeBytes(nil, startKey), codec.EncodeBytes(nil, endKey)) |
There was a problem hiding this comment.
We don't need to append timestamp here.
|
LGTM |
zimulala
approved these changes
Apr 12, 2018
|
/run-all-tests |
zimulala
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MVCC store, we encode keys to memcomparable format and append ts to it. However the DeleteRange method didn't encode it.
The new test case in
mock_tikv_test.goreveals this problem, and now it's fixed.