ddl: check if the column name already exists when we rename the column name #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-test |
jackysp
reviewed
Apr 13, 2018
| @@ -1350,6 +1350,14 @@ func (d *ddl) getModifiableColumnJob(ctx sessionctx.Context, ident ast.Ident, or | |||
| if col == nil { | |||
| return nil, infoschema.ErrColumnNotExists.GenByArgs(originalColName, ident.Name) | |||
| } | |||
| newColName := specNewColumn.Name.Name | |||
| // If we want to rename the column name, we need to check whether it already exists. | |||
| if newColName.L != originalColName.L { | |||
There was a problem hiding this comment.
Why we need to check it twice? Both in ddl_api.go and column.go .
There was a problem hiding this comment.
Because it is possible to have two identical rename operations in the DDL job list at the same time.
There was a problem hiding this comment.
So the go test coverage will cover the both?
|
/run-all-tests |
|
LGTM |
|
PTAL @shenli |
|
LGTM |
shenli
approved these changes
Apr 16, 2018
shenli
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to rename the column name, we need to check whether it already exists.