session: add session variable tidb_optimizer_selectivity_level.
#6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
changed the title
tidb_optimization_level.tidb_optimizer_selectivity_level.
shenli
reviewed
Apr 16, 2018
session/session.go
Outdated
| @@ -1270,7 +1270,8 @@ const loadCommonGlobalVarsSQL = "select HIGH_PRIORITY * from mysql.global_variab | |||
| variable.TiDBIndexLookupJoinConcurrency + quoteCommaQuote + | |||
| variable.TiDBIndexSerialScanConcurrency + quoteCommaQuote + | |||
| variable.TiDBHashJoinConcurrency + quoteCommaQuote + | |||
| variable.TiDBDistSQLScanConcurrency + "')" | |||
| variable.TiDBDistSQLScanConcurrency + quoteCommaQuote + | |||
| variable.TiDBOptimizerSelectivityLevel + "')" | |||
There was a problem hiding this comment.
We do not need to make it a global variable.
alivxxx
reviewed
Apr 16, 2018
sessionctx/variable/session.go
Outdated
| @@ -319,6 +319,8 @@ type SessionVars struct { | |||
| MemQuotaIndexLookupJoin int64 | |||
| // MemQuotaNestedLoopApply defines the memory quota for a nested loop apply executor. | |||
| MemQuotaNestedLoopApply int64 | |||
| // OptimizationLevel defines the level of tidb's planner. | |||
| OptimizationLevel int64 | |||
alivxxx
reviewed
Apr 16, 2018
sessionctx/variable/session.go
Outdated
| @@ -319,6 +319,8 @@ type SessionVars struct { | |||
| MemQuotaIndexLookupJoin int64 | |||
| // MemQuotaNestedLoopApply defines the memory quota for a nested loop apply executor. | |||
| MemQuotaNestedLoopApply int64 | |||
| // OptimizerSelectivityLevel defines the level of tidb's planner. | |||
There was a problem hiding this comment.
The comment needs to be updated as well.
zz-jason
reviewed
Apr 16, 2018
sessionctx/variable/varsutil.go
Outdated
| @@ -128,7 +128,7 @@ func TiDBOptOn(opt string) bool { | |||
| return strings.EqualFold(opt, "ON") || opt == "1" | |||
| } | |||
|
|
|||
| func tidbOptPositiveInt(opt string, defaultVal int) int { | |||
| func tidbOptInt32(opt string, defaultVal int) int { | |||
There was a problem hiding this comment.
I think the old name is more specific, maybe we should revert this name refactor ?
There was a problem hiding this comment.
it has another function called tidbOptInt64
There was a problem hiding this comment.
tidbOptInt64 doesn't check whether this values is positive, while tidbOptPositiveInt does.
There was a problem hiding this comment.
maybe tidbOptPositiveInt32 is a good name ?
zz-jason
reviewed
Apr 16, 2018
sessionctx/variable/tidb_vars.go
Outdated
| @@ -98,6 +98,9 @@ const ( | |||
|
|
|||
| // tidb_enable_streaming enables TiDB to use streaming API for coprocessor requests. | |||
| TiDBEnableStreaming = "tidb_enable_streaming" | |||
|
|
|||
| // tidb_optimizer_selectivity_level is used for control the content of each operator's statistic information. | |||
There was a problem hiding this comment.
may be we can simplify the comment to "is used to control the selectivity estimation level"?
zz-jason
reviewed
Apr 16, 2018
sessionctx/variable/session.go
Outdated
| @@ -319,6 +319,9 @@ type SessionVars struct { | |||
| MemQuotaIndexLookupJoin int64 | |||
| // MemQuotaNestedLoopApply defines the memory quota for a nested loop apply executor. | |||
| MemQuotaNestedLoopApply int64 | |||
| // OptimizerSelectivityLevel defines the what content operator will hold in its statistic information. The higher it | |||
| // is, the more complex content operator will hold. | |||
|
/run-all-tests |
coocood
reviewed
Apr 16, 2018
| @@ -128,7 +128,7 @@ func TiDBOptOn(opt string) bool { | |||
| return strings.EqualFold(opt, "ON") || opt == "1" | |||
| } | |||
|
|
|||
| func tidbOptPositiveInt(opt string, defaultVal int) int { | |||
| func tidbOptPositiveInt32(opt string, defaultVal int) int { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will take effect in future.
PTAL @coocood @zz-jason @lamxTyler