Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support table partition in show create table stmt #6292

Merged
merged 4 commits into from
Apr 16, 2018
Merged

executor: support table partition in show create table stmt #6292

merged 4 commits into from
Apr 16, 2018

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Apr 16, 2018 •
edited
Loading

support table partition in show create table statement.

@zhexuany
Copy link
Contributor Author

zhexuany commented Apr 16, 2018 •
edited
Loading

Regarding of range partition, some syntaxes are not yet supported. Further change will be made later.

@zhexuany
Copy link
Contributor Author

@coocood @ciscoxll PTAL

@coocood
Copy link
Member

coocood commented Apr 16, 2018

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao
Copy link
Contributor

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Apr 16, 2018 •
edited
Loading

I think the create partition syntax with max value is wrong. @zhexuany @coocood

@coocood
Copy link
Member

coocood commented Apr 16, 2018

@jackysp
It can be executed in MySQL.

@coocood
Copy link
Member

coocood commented Apr 16, 2018

/run-unit-test

@zhexuany zhexuany merged commit 0d7a71c into pingcap:master Apr 16, 2018
@zhexuany zhexuany deleted the support_table_partition_in_show_create_table branch April 16, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@shenli shenli Awaiting requested review from shenli

@jackysp jackysp Awaiting requested review from jackysp

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhexuany @coocood @tiancaiamao @jackysp