ddl: support the rolling upgrade. #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
winkyao
added
priority/P1
zz-jason
previously approved these changes
Apr 17, 2018
|
/run-all-tests |
zimulala
added
status/LGT2
coocood
approved these changes
Apr 17, 2018
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Apr 17, 2018
zimulala
added a commit
to zimulala/tidb
that referenced
this pull request
Apr 17, 2018
shenli
pushed a commit
that referenced
this pull request
Apr 17, 2018
coocood
pushed a commit
that referenced
this pull request
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this PR(#6274) as the dividing line to define whether it is a new version or an old version TiDB.
The old version TiDB initializes the column's offset and state here.
The new version TiDB doesn't initialize the column's offset and state, and it will do the initialization in run DDL function.
When we do the rolling upgrade the following may happen:
a new version TiDB builds the DDL job that doesn't be set the column's offset and state,
and the old version TiDB is the DDL owner, it doesn't get offset and state from the store. Then it will encounter errors.
This PR will fix it.