plan: fix a bug in topn_push_down rule.
#6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
/run-all-tests |
shenli
added
sig/planner
|
Do we need to cherry-pick this to the release-2.0? |
|
@shenli Yes, we'd better pick it. |
alivxxx
added
status/LGT2
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Jun 28, 2018
zz-jason
pushed a commit
that referenced
this pull request
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
ColumnIndiceswill returnnilif not all column in the schema.So here will perform wrong action if the by item contains column from both sides.
What are the type of the changes (mandatory)?
The currently defined types are listed below, please pick one of the types for this PR by removing the others:
How has this PR been tested (mandatory)?
unit test.
Refer to a related PR or issue link (optional)
fix #6864