Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, session: replace new line and add user in query log (#6748) #6920

Merged
merged 1 commit into from
Jun 27, 2018
Merged

executor, session: replace new line and add user in query log (#6748) #6920

merged 1 commit into from
Jun 27, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jun 27, 2018

What have you changed? (mandatory)

cherry pick #6748

refer #6898

What are the type of the changes (mandatory)?

  • Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested (mandatory)?

  • unit test
  • integration test

This change is Reviewable

So we can grep a keyword to get the query, without the need to look up the query in the full log.
user name is also needed for auditing purpose.
@lysu
Copy link
Contributor Author

lysu commented Jun 27, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Jun 27, 2018

LGTM

@coocood coocood merged commit 6207c48 into pingcap:release-2.0 Jun 27, 2018
@lysu lysu deleted the dev-cherry-pick-slow-log branch June 27, 2018 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants