privilege/privileges: don't reuse chunk in loadTable function #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
zhexuany
reviewed
Jul 4, 2018
privilege/privileges/cache.go
Outdated
| for { | ||
| // WARNNING: decodeTableRow decodes data from a chunk Row, that is a shallow copy. |
There was a problem hiding this comment.
I hardly saw "WARNNING" in codebase, but Note or NOTE.
|
/run-all-tests tidb-test=pr/562 |
zz-jason
added
status/LGT2
|
CI is currently down... |
|
/run-all-tests |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Jul 4, 2018
shenli
pushed a commit
that referenced
this pull request
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Don't reuse chunk in
loadTablefunction.The memory from the chunk is shallow copy, and
MySQLPrivilegestruct data may be overwritten sometime later, lead to weird TiDB behavior.What are the type of the changes (mandatory)?
PTAL @XuHuaiyu @zz-jason @coocood