Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: update comment wording #7238

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

CaitinChen
Copy link
Contributor

What have you changed? (mandatory)

Update comment wording

What is the type of the changes? (mandatory)

Improvement

How has this PR been tested? (mandatory)

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

No

Does this PR affect tidb-ansible update? (mandatory)

No

Does this PR need to be added to the release notes? (mandatory)

No

Via #7068
@winoros @zz-jason PTAL

Notes:

  • "i.e." means "that is" rather than "for example"; "e.g." means "for example".
  • "The length of A is equal to the length of B" is right; "The length of A is equal to B" is wrong. Because you are comparing "length" with "length".

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit cc1c3be into pingcap:master Aug 2, 2018
@CaitinChen CaitinChen deleted the update-comment-wording branch August 2, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants