expression: fix out of range error for intdiv #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zz-jason PTAL |
|
Thanks @mccxj ! |
jackysp
added
contribution
jackysp
reviewed
Aug 27, 2018
expression/builtin_arithmetic.go
Outdated
| func (s *builtinArithmeticIntDivideDecimalSig) evalInt(row chunk.Row) (ret int64, isNull bool, err error) { | ||
| sc := s.ctx.GetSessionVars().StmtCtx | ||
| var num [2]*types.MyDecimal | ||
| for i, arg := range s.args[0:2] { |
There was a problem hiding this comment.
Should we return an error if len(args) is not 2?
There was a problem hiding this comment.
argument validation should not be done in this phase.
There was a problem hiding this comment.
So use s.args is also safe here?
There was a problem hiding this comment.
oh， I forgot it. use s.args is enough.
|
@jackysp PTAL |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#4477
What is changed and how it works?
see https://github.com/mysql/mysql-server/blob/913071c0b16cc03e703308250d795bc381627e37/sql/item_func.cc#L2232
mysql's behavior:
Check List
Tests
Code changes
Side effects
Related changes