ddl:fix create partitioned table with bigint column fail #7520

ciscoxll · 2018-08-28T18:11:42Z

What problem does this PR solve?

Create partitioned table when partitioning key is of type bigint unsigned will fail.

Fix issue create partitioned table with bigint column fail #7498

What is changed and how it works?

The partitioning key must be an integer, or an expression that returns an integer.
For PartitionRangeValue range comparison.
- Unsigned bigint was converted to uint64 handle.
- Bigint was converted to int64 handle.

mysql

mysql> create table t1 (a bigint unsigned not null) partition by range(a) (
    ->   partition p0 values less than (10),
    ->   partition p1 values less than (100),
    ->   partition p2 values less than (1000),
    ->   partition p3 values less than (18446744073709551000),
    ->   partition p4 values less than (18446744073709551614)
    -> );
Query OK, 0 rows affected (0.07 sec)

mysql> insert into t1 values (5),(15),(105),(1005);
Query OK, 4 rows affected (0.00 sec)
Records: 4  Duplicates: 0  Warnings: 0

mysql> insert into t1 values (18446744073709551000+1);
Query OK, 1 row affected (0.00 sec)

mysql> insert into t1 values (18446744073709551614-1);
Query OK, 1 row affected (0.00 sec)

master branch

mysql> create table t1 (a bigint unsigned not null) partition by range(a) (
    ->   partition p0 values less than (10),
    ->   partition p1 values less than (100),
    ->   partition p2 values less than (1000),
    ->   partition p3 values less than (18446744073709551000),
    ->   partition p4 values less than (18446744073709551614)
    -> );
ERROR 1493 (HY000): VALUES LESS THAN value must be strictly increasing for each partition

Check List

Tests

Unit test

zimulala · 2018-08-29T06:15:03Z

ddl/partition.go

+	var offset int
+	for i, col := range cols {
+		if col.Name.L == strings.ToLower(pi.Expr) {
+			offset = i


Do we need “break” here？

zimulala · 2018-08-29T06:19:49Z

ddl/partition.go

 	for i := 0; i < len(defs); i++ {
 		if strings.EqualFold(defs[i].LessThan[0], partitionMaxValue) {
 			return errors.Trace(ErrPartitionMaxvalue)
 		}

-		currentRangeValue, fromExpr, err := getRangeValue(ctx, tblInfo, defs[i].LessThan[0])
+		currentRangeValue, fromExpr, err := getRangeValue(ctx, tblInfo, defs[i].LessThan[0], cols, offset)


Could we replace “cols” and “offset” with “col”？

ciscoxll · 2018-08-29T07:38:06Z

@tiancaiamao @winkyao @zimulala PTAL .

zimulala · 2018-08-29T08:05:44Z

ddl/partition.go

-	var prevRangeValue int64
+
+	var offset int
+	for i, col := range cols {


Cloud we use "FindCol" directly?

tiancaiamao · 2018-08-29T12:10:07Z

ddl/partition.go

-
-		if currentRangeValue <= prevRangeValue {
-			return errors.Trace(ErrRangeNotIncreasing)
+		if col.Tp == mysql.TypeLonglong && mysql.HasUnsignedFlag(col.Flag) {


col maybe nil here ?

tiancaiamao · 2018-08-29T12:11:21Z

ddl/partition.go

@@ -187,13 +187,15 @@ func checkCreatePartitionValue(ctx sessionctx.Context, tblInfo *model.TableInfo,
 	if strings.EqualFold(defs[len(defs)-1].LessThan[0], partitionMaxValue) {
 		defs = defs[:len(defs)-1]
 	}
-	var prevRangeValue int64
+
+	col := table.FindCol(cols, strings.ToUpper(pi.Expr))


FindCol use a case-insensitive search, so strings.ToUpper is not necessary

ciscoxll · 2018-08-30T03:18:34Z

@tiancaiamao @winkyao @zimulala PTAL .

zhexuany · 2018-08-30T06:16:21Z

ddl/partition.go

@@ -388,3 +406,15 @@ func checkConstraintIncludePartKey(partkeys []string, constraints map[string]str
 	}
 	return true
 }
+
+// FindRangePartitionColTp find the type of the partitioning key column type.


s/FindRangePartitionColTp find the type of the partitioning key column type./FindRangePartitionColTp finds the type of the partitioning key column type.

zhexuany · 2018-08-30T07:22:01Z

/run-all-tests

ciscoxll · 2018-08-30T09:44:28Z

/run-all-tests

tiancaiamao · 2018-08-30T11:43:36Z

ddl/partition.go

-	if value, err := strconv.ParseInt(str, 10, 64); err == nil {
-		return value, false, nil
-	}
+func getRangeValue(ctx sessionctx.Context, tblInfo *model.TableInfo, str string, ifUnsignedBigint bool) (interface{}, bool, error) {


s/ifUnsignedBigint/unsignedBigint

tiancaiamao · 2018-08-30T11:50:12Z

ddl/partition.go

+
+// FindRangePartitionColTp finds the type of the partitioning key column type.
+// The returned boolean value indicates whether the partitioning key column type is unsigned bigint type.
+func FindRangePartitionColTp(cols []*table.Column, pi *model.PartitionInfo) bool {


s/FindRangePartitionColTp/isRangePartitionColUnsignedBigint

Find column type returns a boolean is weird.

ciscoxll · 2018-08-30T12:35:50Z

@tiancaiamao @winkyao @zimulala PTAL .

tiancaiamao · 2018-08-30T16:33:13Z

LGTM

ciscoxll · 2018-08-31T06:26:37Z

@crazycs520 @winkyao @zimulala PTAL .

ddl/partition.go

ciscoxll · 2018-09-03T06:17:33Z

@crazycs520 @winkyao @zimulala PTAL .

crazycs520

LGTM

crazycs520 · 2018-09-04T05:49:33Z

/run-all-tests

zhexuany

LGTM

ciscoxll added the component/DDL-need-LGT3 label Aug 29, 2018

zimulala reviewed Aug 29, 2018

View reviewed changes

ddl/partition.go Outdated

var prevRangeValue int64

var offset int

for i, col := range cols {

Copy link

Contributor

zimulala Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud we use "FindCol" directly?

tiancaiamao reviewed Aug 29, 2018

View reviewed changes

ciscoxll changed the title ~~ddl:create partitioned table with bigint column fail~~ ddl:fix create partitioned table with bigint column fail Aug 30, 2018

zhexuany reviewed Aug 30, 2018

View reviewed changes

ddl:fix create partitioned table with bigint column fail

2c1fb5b

ciscoxll force-pushed the create-partition branch from 6a10006 to 2c1fb5b Compare August 30, 2018 09:12

ciscoxll added the status/all tests passed label Aug 30, 2018

tiancaiamao reviewed Aug 30, 2018

View reviewed changes

address comment

bfc3534

tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2018

crazycs520 reviewed Aug 31, 2018

View reviewed changes

ddl/partition.go Show resolved Hide resolved

crazycs520 reviewed Sep 4, 2018

View reviewed changes

crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 4, 2018

Merge branch 'master' into create-partition

5b4e58d

zhexuany approved these changes Sep 4, 2018

View reviewed changes

ciscoxll added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 4, 2018

ciscoxll added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 4, 2018

Merge branch 'master' into create-partition

87d738d

ciscoxll merged commit 129f499 into pingcap:master Sep 4, 2018

ciscoxll deleted the create-partition branch September 4, 2018 08:01

sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019

you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl:fix create partitioned table with bigint column fail #7520

ddl:fix create partitioned table with bigint column fail #7520

ciscoxll commented Aug 28, 2018 •

edited

Loading

zimulala Aug 29, 2018

zimulala Aug 29, 2018

ciscoxll commented Aug 29, 2018

zimulala Aug 29, 2018

tiancaiamao Aug 29, 2018

tiancaiamao Aug 29, 2018

ciscoxll commented Aug 30, 2018

zhexuany Aug 30, 2018

zhexuany commented Aug 30, 2018

ciscoxll commented Aug 30, 2018

tiancaiamao Aug 30, 2018

tiancaiamao Aug 30, 2018

tiancaiamao Aug 30, 2018

ciscoxll commented Aug 30, 2018

tiancaiamao commented Aug 30, 2018

ciscoxll commented Aug 31, 2018

ciscoxll commented Sep 3, 2018

crazycs520 left a comment

crazycs520 commented Sep 4, 2018

zhexuany left a comment

ddl:fix create partitioned table with bigint column fail #7520

ddl:fix create partitioned table with bigint column fail #7520

Conversation

ciscoxll commented Aug 28, 2018 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ciscoxll commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ciscoxll commented Aug 30, 2018

Choose a reason for hiding this comment

zhexuany commented Aug 30, 2018

ciscoxll commented Aug 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ciscoxll commented Aug 30, 2018

tiancaiamao commented Aug 30, 2018

ciscoxll commented Aug 31, 2018

ciscoxll commented Sep 3, 2018

crazycs520 left a comment

Choose a reason for hiding this comment

crazycs520 commented Sep 4, 2018

zhexuany left a comment

Choose a reason for hiding this comment

ciscoxll commented Aug 28, 2018 •

edited

Loading