Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: remove unused code #7521

Merged
merged 3 commits into from
Aug 29, 2018
Merged

ast: remove unused code #7521

merged 3 commits into from
Aug 29, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 29, 2018

What problem does this PR solve?

Make ast package depends on much less packages.
from 152 packages to 34 packages.

What is changed and how it works?

ast.SubqueryExec and ast.Ident.Full depends on sessionctx package and it is not used.
and sessionctx depends on many packages.

Check List

Tests

  • No code

@coocood coocood added the type/enhancement The issue or PR belongs to an enhancement. label Aug 29, 2018
zimulala
zimulala reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 29, 2018
zhexuany
zhexuany approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member Author

coocood commented Aug 29, 2018

/run-all-tests

@zhexuany zhexuany added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 29, 2018
@tiancaiamao tiancaiamao merged commit 3d468b9 into pingcap:master Aug 29, 2018
@coocood coocood deleted the remove-unused-code branch August 29, 2018 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@zhexuany zhexuany zhexuany approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coocood @zimulala @zhexuany @tiancaiamao