server: make long-data type no longer check nullBitmap #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
changed the title
|
/run-all-tests |
jackysp
added
status/all tests passed
status/LGT1
XuHuaiyu
reviewed
Sep 3, 2018
|
@XuHuaiyu yes, I will do it. |
|
/run-all-tests tidb-test=pr/615 |
shenli
reviewed
Sep 4, 2018
server/conn_stmt.go
Outdated
| if boundParams[i] != nil { | ||
| args[i] = boundParams[i] | ||
| continue | ||
| } | ||
|
|
||
| if nullBitmap[i>>3]&(1<<(uint(i)%8)) > 0 { |
There was a problem hiding this comment.
Please add a comment for the modification.
|
@zhexuany https://github.com/pingcap/tidb-test/pull/615 integration test is enough, fake byte array ut is meanless and hard maintain. |
|
Gotcha. |
|
LGTM |
shenli
approved these changes
Sep 5, 2018
shenli
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #7572
mariadb send none zero value in nullBitmap, tidb follow protocol docs to check nullBitmap and got nul value
but after experiment and check code,
nullBitmapis nouse forLONG_DATA_VALUE(and it's NULL value seem be magic), so we need skip them, and make mariadb client user work.What is changed and how it works?
if param is long_data_value then skip nullBitmap check.
Check List
use mariadb client can reproduce it, after this PR fixed.
Code changes
Side effects
Related changes
This change is