executor: support load data with ignore lines #7576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mccxj Thanks! |
shenli
reviewed
Sep 2, 2018
parser/parser.y
Outdated
| @@ -809,6 +809,7 @@ import ( | |||
| TableOptimizerHintOpt "Table level optimizer hint" | |||
| TableOptimizerHints "Table level optimizer hints" | |||
| TableOptimizerHintList "Table level optimizer hint list" | |||
| IgnoreLines "Ignore num(int) lines" | |||
executor/write_test.go
Outdated
| c.Assert(ok, IsTrue) | ||
| defer ctx.SetValue(executor.LoadDataVarKey, nil) | ||
| c.Assert(ld, NotNil) | ||
| // test escape |
There was a problem hiding this comment.
What do you mean by "test escape"?
There was a problem hiding this comment.
copy comment by mistake.
jackysp
reviewed
Sep 3, 2018
parser/parser.y
Outdated
| @@ -802,6 +802,7 @@ import ( | |||
| OptBinMod "Optional BINARY mode" | |||
| OptCharset "Optional Character setting" | |||
| OptCollate "Optional Collate setting" | |||
| IgnoreLines "Ignore num(int) lines" | |||
shenli
reviewed
Sep 3, 2018
| { | ||
| $$ = uint64(0) | ||
| } | ||
| | "IGNORE" NUM "LINES" |
There was a problem hiding this comment.
In MySQL, a negative number will casue syntax error. Could you add a test case about this?
mysql> load data local infile '/tmp/t.csv' into table t ignore -1 lines;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-1 lines' at line 1
mysql> load data local infile '/tmp/t.csv' into table t ignore 1 lines;
ERROR 1148 (42000): The used command is not allowed with this MySQL version
mysql> quit
|
/run-all-tests |
shenli
approved these changes
Sep 6, 2018
|
@mccxj Thanks! |
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For #7476
What is changed and how it works?
Check List
Tests
Code changes