store/tikv,mysql: improve error message of GC life time #7658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Sep 10, 2018
store/tikv/kv.go
Outdated
| @@ -165,7 +165,7 @@ func (s *tikvStore) CheckVisibility(startTime uint64) error { | |||
| } | |||
|
|
|||
| if startTime < cachedSafePoint { | |||
| return ErrGCTooEarly | |||
| return ErrGCTooEarly.GenByArgs(startTime, cachedSafePoint) | |||
There was a problem hiding this comment.
Are startTime and cachedSafePoint human readable?
There was a problem hiding this comment.
startTime is tso, and the safetime is calculated in GCWorker.prepare, also tso, so both is not readable.
|
@tiancaiamao |
|
LGTM |
|
/run-all-tests |
winkyao
previously approved these changes
Sep 11, 2018
shenli
approved these changes
Sep 11, 2018
|
/run-all-tests |
shenli
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #7650
What is changed and how it works?
Print the transaction start time and GC safe time.
When GC was happened is not easy to know, because the
gcworkermay not run in current TiDB.Check List
Tests
@coocood