Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: fix mistaken conversion from outer join to inner join #7689

Merged
merged 7 commits into from
Sep 17, 2018
Merged

plan: fix mistaken conversion from outer join to inner join #7689

merged 7 commits into from
Sep 17, 2018

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Sep 13, 2018 •
edited
Loading

What problem does this PR solve?

Fix #7687

What is changed and how it works?

exclude upper level join conditions from predicates when simplifying embedded outer join

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@eurekaka
plan: fix mistaken conversion from outer join to inner join
0b9aedb 
exclude upper level join conditions from predicates when simplifying
embedded outer join
@eurekaka
add explain test
ccb0fe1
@eurekaka
add unit test
ffcb245
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

/run-common-test
/run-integration-common-test

@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka
Copy link
Contributor Author

@zz-jason @XuHuaiyu @winoros PTAL

zz-jason
zz-jason reviewed Sep 13, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2018
winoros
winoros reviewed Sep 14, 2018
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that concatOnAndWhereConds can be removed?

@eurekaka
Copy link
Contributor Author

@winoros good catch, thanks. Patch updated.

XuHuaiyu
XuHuaiyu approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2018
@eurekaka eurekaka merged commit 7f6babb into pingcap:master Sep 17, 2018
@eurekaka eurekaka deleted the bug_simplify_outer branch September 17, 2018 05:39
@eurekaka eurekaka mentioned this pull request Oct 15, 2018
Merged
zz-jason pushed a commit that referenced this pull request Oct 15, 2018
@eurekaka @zz-jason
plan: fix mistaken conversion from outer join to inner join (cherry-p…
4fe94f5 
…ick #7689) (#7899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @winoros @XuHuaiyu