-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix add index on timestamp column bug #7724
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
What problem does this PR solve?
reproduce SQL:
In old TiDB version, the SQL:
admin check table t1
will return error cause by wrong index record.What is changed and how it works?
In back fill record to index, if use the column default value, and if the column type is timestamp, We should convert the default timestamp value to UTC timestamp value.
Check List
Tests
Code changes
Related changes