Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: fix format bug for some expressions #7770

Merged
merged 3 commits into from
Sep 23, 2018
Merged

Conversation

mccxj
Copy link
Contributor

@mccxj mccxj commented Sep 23, 2018

What problem does this PR solve?

Some expressions with NOT keyword do not format correctly.

What is changed and how it works?

change Format() to support expressions with NOT keyword.

Check List

Tests

  • Unit test

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2018
@shenli
Copy link
Member

shenli commented Sep 23, 2018

LGTM
@mccxj Thanks!

@shenli
Copy link
Member

shenli commented Sep 23, 2018

/run-all-tests

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2018
@shenli shenli merged commit f457f24 into pingcap:master Sep 23, 2018
@mccxj mccxj deleted the format branch September 23, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants