-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: add json_arrayagg and json_objectagg #7824
Conversation
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
@Kingwl Thanks! |
@shenli could you give some help, please😂 |
62658af
to
6e8d6cc
Compare
@Kingwl What problem do you encountered? |
where should I add the test? |
@Kingwl how about adding test in file |
@zz-jason seems a big work, could I add the JSON agg function only?😂 |
@Kingwl sure, it’s also the recommended way. 😄 |
and the pingcap/tipb#105 has blocked this (and #7776) , could you take a look please?🙋🏻♂️ |
And something can not to be serialized to binary JSON (Decimal), are there any existed way to handle that? |
@Kingwl Why decimal can not be serialized to binary json? |
|
another question: |
@ PTAL @zz-jason |
Hi, @Kingwl, could you please fix these CI problems and conflicts? Thanks~ |
sure |
PTAL~ @Kingwl |
@Kingwl friendly ping, any update? |
Sorry for the delay,I have no time to update with these recently. And the changes seem not completion, Sorry again. |
What problem does this PR solve?
#7623
#7546
What is changed and how it works?
add an aggr function
Check List
Tests
This change is