Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: engines table improved #7831

Merged
merged 2 commits into from
Oct 8, 2018
Merged

infoschema: engines table improved #7831

merged 2 commits into from
Oct 8, 2018

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Oct 5, 2018

What problem does this PR solve?

The information_schema.engines table produced different output to SHOW ENGINES. This PR makes both show just "InnoDB" as the engine, which is more accurate.

What is changed and how it works?

Removed the non-innodb engines from information_schema.engines.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

This has no functional basis, so I've not written unit tests. But I can if you believe we should.

Code changes

  • Minor changes

Side effects

  • Breaking backward compatibility

It is unlikely, but a user could rely on the previous (incorrect) list of engines.

Related changes

  • Need to be included in the release note
  • Update documentation on information_schema.engines (it currently says this table is dummy data, but I would consider it accurate once this PR is pulled.)

Now shows the same result as SHOW ENGINES, which is more accurate.
@shenli
Copy link
Member

shenli commented Oct 6, 2018

LGTM

@shenli
Copy link
Member

shenli commented Oct 6, 2018

@coocood PTAL

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 6, 2018
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any special reason that we have 2 separate hard-coded data sources for show and information_schema? e.g, dataForEngines and fetchShowEngines here. Should we convert show to select * from information_schema.xxx in the long run?

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2018
@eurekaka
Copy link
Contributor

eurekaka commented Oct 8, 2018

/run-all-tests

@shenli
Copy link
Member

shenli commented Oct 8, 2018

@eurekaka No special reason. We could merge them together.

@morgo
Copy link
Contributor Author

morgo commented Oct 8, 2018

@eurekaka I was wondering the same thing. In MySQL SHOW commands are aliases to information_schema.

There are also other SHOW + infoschema commands which are inconsistent, for example SHOW TABLE STATUS does not have the new meta data added in #7657

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit c16a94d into pingcap:master Oct 8, 2018
@morgo morgo deleted the infoschema_engines branch October 8, 2018 03:13
morgo added a commit to pingcap/docs that referenced this pull request Oct 26, 2018
It was improved to no longer show dummy data: pingcap/tidb#7831
shenli pushed a commit to pingcap/docs that referenced this pull request Oct 29, 2018
It was improved to no longer show dummy data: pingcap/tidb#7831
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants