-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: engines table improved #7831
Conversation
Now shows the same result as SHOW ENGINES, which is more accurate.
LGTM |
@coocood PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any special reason that we have 2 separate hard-coded data sources for show
and information_schema
? e.g, dataForEngines
and fetchShowEngines
here. Should we convert show
to select * from information_schema.xxx
in the long run?
/run-all-tests |
@eurekaka No special reason. We could merge them together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It was improved to no longer show dummy data: pingcap/tidb#7831
It was improved to no longer show dummy data: pingcap/tidb#7831
What problem does this PR solve?
The
information_schema.engines
table produced different output toSHOW ENGINES
. This PR makes both show just "InnoDB" as the engine, which is more accurate.What is changed and how it works?
Removed the non-innodb engines from
information_schema.engines
.Check List
Tests
This has no functional basis, so I've not written unit tests. But I can if you believe we should.
Code changes
Side effects
It is unlikely, but a user could rely on the previous (incorrect) list of engines.
Related changes