Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: print arguments in execute statement in log files (#7684) #8053

Merged
merged 1 commit into from
Oct 25, 2018
Merged

executor: print arguments in execute statement in log files (#7684) #8053

merged 1 commit into from
Oct 25, 2018

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Oct 25, 2018

What problem does this PR solve?

Cherry-pick #7684 to release 2.1
PTAL @tiancaiamao @lysu

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. type/2.1 cherry-pick labels Oct 25, 2018
zimulala
zimulala reviewed Oct 25, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2018
zz-jason
zz-jason approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2018
@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.1 tikv-test=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 7fb086f into pingcap:release-2.1 Oct 25, 2018
@jackysp jackysp deleted the print_log_2.1 branch October 25, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackysp @zz-jason @zimulala