Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: use pumps client to write binlog #8098

Merged
merged 3 commits into from
Oct 30, 2018
Merged

binlog: use pumps client to write binlog #8098

merged 3 commits into from
Oct 30, 2018

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

cherry pick commit from master

What is changed and how it works?

git cherry-pick 508f5dd
resolve some conflicts

Check List

Tests

  • Unit test

Related changes

  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2018
@zz-jason
Copy link
Member

@lamxTyler @winoros PTAL

@winoros
Copy link
Member

winoros commented Oct 29, 2018

@WangXiangUSTC gofmt failed. You may need to run it locally and push a patch.

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

1 similar comment
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@WangXiangUSTC
Copy link
Contributor Author

@winoros PTAL again

zimulala
zimulala approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 30, 2018
@zimulala zimulala merged commit 6999f64 into pingcap:release-2.1 Oct 30, 2018
@WangXiangUSTC WangXiangUSTC deleted the xiang/cherry-pick branch November 11, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @zz-jason @winoros @zimulala @shenli