Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix cast json to decimal bug. (#8030) #8109

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

crazycs520
Copy link
Contributor

cherry-pick from #8030.

@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor

should we also cherry-pick this to release-2.0.

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

PTAL @zz-jason @eurekaka

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 01c9d82 into pingcap:release-2.1 Oct 31, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. component/expression type/bugfix This PR fixes a bug. labels Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants