Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]*: add a variable to control whether we can write _tidb_rowid #8187

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Nov 5, 2018

What problem does this PR solve?

create table tt(id binary(10), c int, primary key(id));
insert tt values (1, 10);
insert into tt (id, c, _tidb_rowid) values(30000,10,1);
tidb> select * from tt use index(`primary`);
+------------+------+
| id         | c    |
+------------+------+
| 30000      |   10 |
| 30000      |   10 |
+------------+------+
2 rows in set (0.00 sec)
tidb> select * from tt;
+------------+------+
| id         | c    |
+------------+------+
| 30000      |   10 |
+------------+------+
1 row in set (0.00 sec)

What is changed and how it works?

cherry-pick #8126

@zimulala
Copy link
Contributor Author

zimulala commented Nov 5, 2018

/run-all-tests

@zimulala zimulala added sig/execution SIG execution type/bugfix This PR fixes a bug. labels Nov 5, 2018
@zimulala
Copy link
Contributor Author

zimulala commented Nov 5, 2018

PTAL @winkyao @zz-jason @jackysp

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Nov 5, 2018
@zz-jason zz-jason merged commit 693ff90 into pingcap:master Nov 5, 2018
@zimulala zimulala deleted the rowid branch November 6, 2018 02:53
zimulala added a commit to zimulala/tidb that referenced this pull request Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants