ddl: dynamic adjust add index worker number. #8295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
force-pushed
the
adjust-add-index-worker
branch
from
604526b
to
f936c59
Compare
…add-index-worker
|
/run-all-tests |
crazycs520
changed the title
|
/run-all-tests |
|
/run-integration-ddl-test |
1 similar comment
|
/run-integration-ddl-test |
|
@crazycs520 Please find out why integration-ddl-test failed, https://github.com/pingcap/tidb-test/tree/master/ddl_test |
winkyao
reviewed
Nov 20, 2018
ddl/db_test.go
Outdated
| } | ||
| if startReorganization { | ||
| workerCnt := rand.Intn(8) + 8 | ||
| s.mustExec(c, fmt.Sprintf("set @@tidb_ddl_reorg_worker_cnt=%d", workerCnt)) |
There was a problem hiding this comment.
How can we ensure the worker count is changed to workerCnt?
There was a problem hiding this comment.
em... I check the log when do manual test to know the worker count is changed... 😂
winkyao
reviewed
Nov 20, 2018
winkyao
reviewed
Nov 20, 2018
zimulala
reviewed
Dec 19, 2018
ddl/index.go
Outdated
| } | ||
|
|
||
| reorgInfo.d.mu.Lock() | ||
| reorgInfo.d.mu.hook.OnIndexWorkerReorgBefore(len(idxWorkers), len(kvRanges)) |
There was a problem hiding this comment.
Could we use gofail instead of this logic？
ddl/db_test.go
Outdated
| @@ -630,8 +680,16 @@ LOOP: | |||
| s.mustExec(c, sql) | |||
| } | |||
| num += step | |||
| case <-ticker2.C: | |||
| if changeWorkerNumEnable { | |||
…add-index-worker
crazycs520
force-pushed
the
adjust-add-index-worker
branch
from
0befa35
to
d86e5b4
Compare
crazycs520
force-pushed
the
adjust-add-index-worker
branch
from
d86e5b4
to
77f49bd
Compare
|
/run-all-tests |
…add-index-worker
|
/run-all-tests |
zimulala
requested changes
Dec 21, 2018
ddl/db_test.go
Outdated
| s.tk.MustExec("drop table test_add_index") | ||
| } | ||
|
|
||
| func (s *testDBSuite) TestAddIndexWorkerNum(c *C) { |
There was a problem hiding this comment.
Please put it to failtest/fail_db_test.go
crazycs520
force-pushed
the
adjust-add-index-worker
branch
from
fcd092d
to
50470ad
Compare
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
…add-index-worker
crazycs520
force-pushed
the
adjust-add-index-worker
branch
from
a2d1db9
to
fc6674e
Compare
|
/run-all-tests |
zimulala
reviewed
Dec 22, 2018
|
|
||
| // gofail: var checkIndexWorkerNum bool | ||
| //if checkIndexWorkerNum { | ||
| // num := int(atomic.LoadInt32(&TestCheckWorkerNumber)) |
There was a problem hiding this comment.
Maybe we don't need atomic.LoadInt3.
There was a problem hiding this comment.
Use to avoid data race.
zimulala
approved these changes
Dec 24, 2018
|
/run-all-tests |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Dec 24, 2018
zz-jason
pushed a commit
that referenced
this pull request
Dec 25, 2018
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, if tidb is doing a add index ddl job, then the client change the
tidb_ddl_reorg_worker_cntwant to speed up add index, but this change will take effect next add index, won't affect current add index job.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
This change is