executor: properly escape backquotes in identifiers in SHOW CREATE TABLE #8302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
force-pushed
the
fix-8259
branch
2 times, most recently
from
f6377f8 to
4e90eed
Compare
kennytm
added
type/bugfix
|
/run-all-tests |
|
/run-integration-ddl-test |
kennytm
added
status/LGT2
|
@kennytm we should cherry pick this change to release-2.1 and release-2.0 branch |
kennytm
added a commit
to kennytm/tidb
that referenced
this pull request
Nov 14, 2018
kennytm
added a commit
to kennytm/tidb
that referenced
this pull request
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8259.
What is changed and how it works?
Added a method which properly escapes and doubles the backquotes in an identifier (
"foo`bar"→"`foo``bar`")In the implementation of SHOW CREATE TABLE and SHOW CREATE DATABASE, we replaced all usages of
fmt.Sprintf("`%s`", stuff.Name.O)intoescape(stuff.Name, sqlMode).Check List
Tests
Code changes
Side effects
Related changes