-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove junk from go.sum #8364
remove junk from go.sum #8364
Conversation
@tiancaiamao PTAL |
/run-all-tests |
LGTM |
LGTM |
go.sum is maintained by tools (go toolchain) automanically, that's not junk. |
https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file
And here: We should just take care of the |
See in PD where this same thing happened: there were dependencies showing up that made no sense. Then the process was done more carefully and the dependencies were no longer there. Unfortunately I don't have deep insight into the go mod process. The only thing I can say for certain is that airbrake was not a dependency before go modules and then showed up afterwards, and that we certainly don't use it. I run |
What problem does this PR solve?
In the transition to go modules some junk was added to tidb's dependencies. #8054
Code review pointed this out and also the fact that any of the dependencies may have changed from what they were pegged at, but these issues has not been addressed.
This PR just removes some obvious junk.
What is changed and how it works?
I deleted a couple weird things in the go.sum
Tests
If it compiles it should work.
This change is