Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: privilege check ANALYZE TABLE stmt #8486

Merged
merged 6 commits into from
Dec 28, 2018
Merged

planner: privilege check ANALYZE TABLE stmt #8486

merged 6 commits into from
Dec 28, 2018

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Nov 28, 2018 •
edited
Loading

What problem does this PR solve?

Fixes #5277

What is changed and how it works?

Check for both SELECT and INSERT privilege, per MySQL compatibility.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Minimal

Side effects

  • Breaking backward compatibility (for broken apps)

Related changes

  • Need to be included in the release note

This change is Reviewable

@morgo
Copy link
Contributor Author

morgo commented Nov 28, 2018

/run-all-tests

@zz-jason zz-jason added the sig/planner SIG: Planner label Nov 28, 2018
@morgo morgo mentioned this pull request Dec 27, 2018
Closed
@morgo
Copy link
Contributor Author

morgo commented Dec 27, 2018

Thank you for the feedback, I've incorporated the changes.. and it looks a lot cleaner.

One thing I don't like about visitInfo is the MySQL error codes don't match, but this is an existing problem. I have created #8838 to address.

PTAL @eurekaka, @lamxTyler

alivxxx
alivxxx reviewed Dec 27, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 27, 2018
@shenli
Copy link
Member

shenli commented Dec 27, 2018

@tiancaiamao @lysu PTAL

@shenli
Copy link
Member

shenli commented Dec 27, 2018

/run-all-tests

eurekaka
eurekaka approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2018
@eurekaka eurekaka merged commit fe01b16 into pingcap:master Dec 28, 2018
@morgo morgo deleted the analyze branch December 28, 2018 03:13
AndrewDi pushed a commit to AndrewDi/tidb that referenced this pull request Dec 28, 2018
@morgo @AndrewDi
planner: privilege check ANALYZE TABLE stmt (pingcap#8486)
fcd15f7
yu34po pushed a commit to yu34po/tidb that referenced this pull request Jan 2, 2019
@morgo @yu34po
planner: privilege check ANALYZE TABLE stmt (pingcap#8486)
b80e714
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check privilege for analyze statement
6 participants
@morgo @shenli @eurekaka @alivxxx @zz-jason @sre-bot