-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix abs push down sign bug (#8622) #8628
Conversation
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
Can we use tidb-test master? some script in tidb-test not cherry-pick to release2.1 now |
@zhouqiang-cl run tidb-test@master with 2.1/2.0 branch code maybe cannot pass all testcase |
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
LGTM |
@zhouqiang-cl Seems the CI script is not correct:
PTAL |
@zhouqiang-cl We can't. |
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/rebuild |
1 similar comment
/rebuild |
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
cherry-pick #8622 to 2.1
This change is