Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner,expression: use constraint propagation in partition pruning #8885
planner,expression: use constraint propagation in partition pruning #8885
Changes from 19 commits
6cbf528
f966b75
e11f0ed
12d9212
3376571
9a3659b
b3287fc
0f08c3e
934bddd
bdcf799
c661aa7
c3bddb8
1939df5
32dae16
4a5735e
bf90c2a
10fb9b1
084ce7a
8518cc0
03aff65
5bec8fc
7d57f56
0a52d72
5f5acb1
1b0825b
89e597f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check
partCol == nil
first when entering this function?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean check
partCol == nil
at the beginning of this function and return false? No we can't do that.In
to_days(c) > xx and c < yy
,partCol
is nil, but I want to handle it.If this branch moved to the beginning, the
canBePruned
will return immediately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Could you add a comment about this to let others know why we intentionally put this check after
solver.Solve()
?