ddl: modify cancel drop column ddl test
#8897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscoxll
force-pushed
the
drop-column-test
branch
from
d96a75e
to
33291a2
Compare
|
@crazycs520 PTAL |
zimulala
reviewed
Jan 2, 2019
1 similar comment
ciscoxll
added
status/LGT2
zimulala
added
status/LGT3
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #8897 +/- ##
==========================================
+ Coverage 67.54% 67.55% +0.01%
==========================================
Files 363 363
Lines 75264 75264
==========================================
+ Hits 50835 50845 +10
+ Misses 19938 19932 -6
+ Partials 4491 4487 -4
Continue to review full report at Codecov.
|
|
/run-all-tests |
|
/run-all-tests |
zhexuany
pushed a commit
to zhexuany/tidb
that referenced
this pull request
Jan 10, 2019
* modify cancel drop column ddl test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
From #8545
TestCancelJobthe test here is invalid.What is changed and how it works?
In the test of
cancel drop column, if column does not exist, you need to add column first, cancel job and check it separately.StateDeleteOnlyandStateWriteOnlyandStateWriteReorganizationare in compliance with expectations.Check List
Tests
This change is