Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl :fix cancel add/drop partitioned table ddl job #8938

Merged
merged 4 commits into from
Feb 19, 2019
Merged

ddl :fix cancel add/drop partitioned table ddl job #8938

merged 4 commits into from
Feb 19, 2019

Conversation

ciscoxll
Copy link
Contributor

@ciscoxll ciscoxll commented Jan 4, 2019 •
edited
Loading

What problem does this PR solve?

We can only cancel add partitioned table job when the job state is on JobStateNone , if the job status is JobStateDone or JobStateRunning, the job will not be canceled.

What is changed and how it works?

Only added tests.

Check List

Tests

  • Unit test

This change is Reviewable

@ciscoxll ciscoxll changed the title ddl :fix cancel add table partition ddl job ddl :fix cancel add partitioned table ddl job Jan 4, 2019
@codecov-io
Copy link

codecov-io commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #8938 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8938      +/-   ##
==========================================
+ Coverage   67.06%   67.07%   +<.01%     
==========================================
  Files         372      372              
  Lines       78026    78043      +17     
==========================================
+ Hits        52332    52346      +14     
- Misses      21016    21023       +7     
+ Partials     4678     4674       -4
Impacted Files Coverage Δ
util/admin/admin.go 66.34% <0%> (-0.49%) ⬇️
ddl/rollingback.go 63.52% <0%> (-5.71%) ⬇️
infoschema/infoschema.go 76.31% <0%> (-1.32%) ⬇️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
store/tikv/scan.go 77.31% <0%> (+3.36%) ⬆️
ddl/delete_range.go 79.36% <0%> (+4.23%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fa006...9e8bb6f. Read the comment docs.

winkyao
winkyao suggested changes Jan 5, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle the corresponding cancel job in convertJob2RollbackJob,

@ciscoxll ciscoxll changed the title ddl :fix cancel add partitioned table ddl job ddl :fix cancel add/drop partitioned table ddl job Jan 7, 2019
@ciscoxll
Copy link
Contributor Author

ciscoxll commented Jan 7, 2019

@winkyao @zimulala @crazycs520 PTAL.

@ciscoxll
Copy link
Contributor Author

@zimulala @crazycs520 PTAL.

@ciscoxll
Copy link
Contributor Author

@crazycs520 @winkyao @zimulala PTAL.

crazycs520
crazycs520 reviewed Jan 14, 2019
View reviewed changes
ddl/rollingback.go Outdated Show resolved Hide resolved
@winkyao
Copy link
Contributor

winkyao commented Jan 16, 2019

@ciscoxll Please address comments.

@ciscoxll
Copy link
Contributor Author

@zimulala @crazycs520 PTAL.

@ciscoxll
Copy link
Contributor Author

@winkyao PTAL

crazycs520
crazycs520 reviewed Feb 19, 2019
View reviewed changes
ddl/rollingback.go Outdated Show resolved Hide resolved
crazycs520
crazycs520 reviewed Feb 19, 2019
View reviewed changes
ddl/rollingback.go Outdated Show resolved Hide resolved
@ciscoxll
Copy link
Contributor Author

@crazycs520 @zimulala PTAL.

crazycs520
crazycs520 reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciscoxll ciscoxll added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 19, 2019
winkyao
winkyao reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala
Copy link
Contributor

/run-all-tests

@ciscoxll ciscoxll added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 19, 2019
@winkyao
Copy link
Contributor

winkyao commented Feb 19, 2019

/run-unit-test

@ciscoxll ciscoxll merged commit 45ee205 into pingcap:master Feb 19, 2019
@ciscoxll ciscoxll deleted the cancel-add-partition branch February 19, 2019 09:22
@ciscoxll ciscoxll mentioned this pull request Feb 20, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@winkyao winkyao winkyao approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/sql-infra SIG: SQL Infra status/LGT3 The PR has already had 3 LGTM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ciscoxll @codecov-io @winkyao @zimulala @crazycs520 @you06 @sre-bot