Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: add plugin package tool #9007

Merged
merged 5 commits into from
Jan 13, 2019
Merged

cmd: add plugin package tool #9007

merged 5 commits into from
Jan 13, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jan 10, 2019 •
edited
Loading

What problem does this PR solve?

standalone part of #8788, add a plugin package tool to avoid write glue code every time.

What is changed and how it works?

generate glue code from toml config.

Check List

Tests

  • WIP: I will refactor it to testable and cover by ut soon.

Code changes

  • New code

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

@lysu lysu mentioned this pull request Jan 10, 2019
Merged
@codecov-io
Copy link

codecov-io commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #9007 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9007      +/-   ##
==========================================
- Coverage   67.55%   67.54%   -0.02%     
==========================================
  Files         364      364              
  Lines       75353    75421      +68     
==========================================
+ Hits        50903    50940      +37     
- Misses      19954    19984      +30     
- Partials     4496     4497       +1
Impacted Files Coverage Δ
store/tikv/gcworker/gc_worker.go 41.14% <0%> (-1.35%) ⬇️
executor/join.go 78.44% <0%> (-0.52%) ⬇️
util/codec/codec.go 57.05% <0%> (+0.35%) ⬆️
types/mydecimal.go 87.19% <0%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4c998...ae9025f. Read the comment docs.

jackysp
jackysp reviewed Jan 10, 2019
View reviewed changes
cmd/pluginpkg/pluginpkg.go Outdated Show resolved Hide resolved
jackysp
jackysp reviewed Jan 10, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add a README file for it.

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2019
jackysp
jackysp approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jan 13, 2019

/run-all-tests

@jackysp
Copy link
Member

jackysp commented Jan 13, 2019

/run-all-tests

@jackysp jackysp merged commit 1d00f75 into pingcap:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/plugin status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @codecov-io @tiancaiamao @jackysp