Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-server: remove the X Server #9038

Merged
merged 4 commits into from
Jan 15, 2019
Merged

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jan 14, 2019

What problem does this PR solve?

X Server is never used in TiDB. It is better to implement it as a plugin as MySQL, due to the plugin framework is supported in TiDB.

What is changed and how it works?

Remove the X Server

Check List

Tests

  • Unit test

@jackysp
Copy link
Member Author

jackysp commented Jan 14, 2019

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@lysu
Copy link
Contributor

lysu commented Jan 14, 2019

/run-integraion-common-test tidb-test=pr/718

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Jan 14, 2019

/run-integration-common-test tidb-test=pr/718

@lysu lysu added component/server status/LGT2 Indicates that a PR has LGTM 2. labels Jan 14, 2019
@lysu
Copy link
Contributor

lysu commented Jan 14, 2019

/run-all-tests

@jackysp
Copy link
Member Author

jackysp commented Jan 15, 2019

/run-unit-test

@codecov-io
Copy link

Codecov Report

Merging #9038 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9038      +/-   ##
==========================================
+ Coverage   67.25%   67.26%   +<.01%     
==========================================
  Files         371      371              
  Lines       76195    76195              
==========================================
+ Hits        51245    51250       +5     
+ Misses      20415    20412       -3     
+ Partials     4535     4533       -2
Impacted Files Coverage Δ
config/config.go 14.54% <ø> (ø) ⬆️
ddl/session_pool.go 82.75% <0%> (-10.35%) ⬇️
util/filesort/filesort.go 76.48% <0%> (+0.94%) ⬆️
ddl/delete_range.go 77.14% <0%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 463d44c...65b07e6. Read the comment docs.

@zz-jason zz-jason merged commit 41838ce into pingcap:master Jan 15, 2019
@jackysp jackysp deleted the remove_xserver branch February 11, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants