infoschema: add table_id to table and add tidb_indexes table. #9183

lysu · 2019-01-25T09:37:08Z

What problem does this PR solve?

now, we can query table_id and index_id from http-api, but in some enviorment, it'
s more convient to use sql.

final usage can be sawed in test case https://github.com/pingcap/tidb/pull/9183/files#diff-9cb2947f24dfdff2e6f6cec84b53aa56R212

What is changed and how it works?

add tidb_table_id column to information_schema.tables
add new tidb_indexes table that contains index_id column

let use query table_id and index_id via sql.

Check List

Tests

Unit test

Code changes

infomation schema: column and table

Side effects

N/A

Related changes

N/A

This change is

lysu · 2019-01-25T09:37:35Z

/run-all-tests

crazycs520

LGTM

codecov-io · 2019-01-27T13:05:30Z

Codecov Report

Merging #9183 into master will increase coverage by 0.03%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master    #9183      +/-   ##
==========================================
+ Coverage   67.21%   67.24%   +0.03%     
==========================================
  Files         371      371              
  Lines       77052    77104      +52     
==========================================
+ Hits        51789    51850      +61     
+ Misses      20634    20629       -5     
+ Partials     4629     4625       -4

Impacted Files	Coverage Δ
infoschema/tables.go	`51.68% <88.46%> (+2.45%)`	⬆️
infoschema/infoschema.go	`76.31% <0%> (-2.64%)`	⬇️
executor/index_lookup_join.go	`77.28% <0%> (-0.64%)`	⬇️
expression/schema.go	`94.95% <0%> (+0.84%)`	⬆️
store/tikv/lock_resolver.go	`42.65% <0%> (+0.94%)`	⬆️
executor/join.go	`78.9% <0%> (+1.04%)`	⬆️
store/tikv/scan.go	`77.31% <0%> (+3.36%)`	⬆️
ddl/delete_range.go	`80.42% <0%> (+5.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3bdc5d...65c5d55. Read the comment docs.

jackysp · 2019-01-28T01:44:51Z

/run-all-tests

infoschema/tables.go

alivxxx · 2019-01-28T05:15:51Z

infoschema/tables.go

+					tb.Name.O,     // TABLE_NAME
+					0,             // NON_UNIQUE
+					"PRIMARY",     // KEY_NAME
+					1,             // SEQ_IN_INDEX


Is 0 better? Or it may coincide with indices?

it's follow

tidb/executor/show.go

Line 419 in e6a0eb9

1, // Seq_in_index

, so there are bug in show index?

maybe we should better let seq start from 1 https://dev.mysql.com/doc/refman/8.0/en/show-index.html

Ok, so it is better to make the seq_in_index be len(rows)+1 for index.

XuHuaiyu · 2019-01-28T06:33:02Z

infoschema/tables.go

+	{"KEY_NAME", mysql.TypeVarchar, 64, 0, nil, nil},
+	{"SEQ_IN_INDEX", mysql.TypeLonglong, 21, 0, nil, nil},
+	{"COLUMN_NAME", mysql.TypeVarchar, 64, 0, nil, nil},
+	{"SUB_PART", mysql.TypeLonglong, 21, 0, nil, nil},


Why not name it as LENGTH?

because show index use this name

XuHuaiyu · 2019-01-28T06:38:04Z

infoschema/tables.go

+				record := types.MakeDatums(
+					schema.Name.O, // TABLE_SCHEMA
+					tb.Name.O,     // TABLE_NAME
+					0,             // NON_UNIQUE


May this 0 confuse others?

just follow show index

tidb/executor/show.go

Line 417 in e6a0eb9

0, // Non_unique

XuHuaiyu · 2019-01-28T06:39:43Z

infoschema/tables.go

+	{"TABLE_SCHEMA", mysql.TypeVarchar, 64, 0, nil, nil},
+	{"TABLE_NAME", mysql.TypeVarchar, 64, 0, nil, nil},
+	{"NON_UNIQUE", mysql.TypeLonglong, 21, 0, nil, nil},
+	{"KEY_NAME", mysql.TypeVarchar, 64, 0, nil, nil},


put this column before NON_UNIQUE?

it's following show index

infoschema/tables.go

infoschema/tables_test.go

eurekaka · 2019-01-29T03:03:31Z

infoschema/tables.go

@@ -1003,6 +1019,68 @@ func dataForTables(ctx sessionctx.Context, schemas []*model.DBInfo) ([][]types.D
 	return rows, nil
 }

+func dataForIndexes(ctx sessionctx.Context, schemas []*model.DBInfo) ([][]types.Datum, error) {


This looks like duplicate code with fetchShowIndex? can we extract it to a separate function for reuse?

good idea, current show table and tables is same to but maybe we can do this in future?

infoschema/tables.go

winkyao

LGTM

jackysp

LGTM

…#9862)

infoschema: add table_id to table and add tidb_indexes table.

9b92470

lysu added type/enhancement The issue or PR belongs to an enhancement. component/server labels Jan 25, 2019

lysu added the status/all tests passed label Jan 25, 2019

crazycs520 reviewed Jan 27, 2019

View reviewed changes

Merge branch 'master' into dev-tbl-idx-id

38ccb3f

crazycs520 reviewed Jan 28, 2019

View reviewed changes

infoschema/tables.go Outdated Show resolved Hide resolved

alivxxx reviewed Jan 28, 2019

View reviewed changes

XuHuaiyu reviewed Jan 28, 2019

View reviewed changes

zimulala reviewed Jan 28, 2019

View reviewed changes

infoschema/tables.go Outdated Show resolved Hide resolved

infoschema/tables_test.go Outdated Show resolved Hide resolved

lysu added 2 commits January 29, 2019 10:34

address comment

bbf2948

address comment

23a8e57

eurekaka reviewed Jan 29, 2019

View reviewed changes

lysu added 2 commits January 29, 2019 12:11

address comment

ced51a4

fix ci

ccdc34f

winkyao reviewed Jan 29, 2019

View reviewed changes

jackysp approved these changes Jan 31, 2019

View reviewed changes

Merge branch 'master' into dev-tbl-idx-id

65c5d55

jackysp merged commit 4c85822 into pingcap:master Jan 31, 2019

lysu mentioned this pull request Mar 22, 2019

infoschema: add table_id to table and add tidb_indexes table. (#9183) #9862

Merged

zz-jason pushed a commit that referenced this pull request Mar 23, 2019

infoschema: add table_id to table and add tidb_indexes table. (#9183) (…

8da8632

…#9862)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

infoschema: add table_id to table and add tidb_indexes table. #9183

infoschema: add table_id to table and add tidb_indexes table. #9183

lysu commented Jan 25, 2019 •

edited

Loading

lysu commented Jan 25, 2019

crazycs520 left a comment

codecov-io commented Jan 27, 2019 •

edited

Loading

jackysp commented Jan 28, 2019

alivxxx Jan 28, 2019 •

edited

Loading

lysu Jan 29, 2019

lysu Jan 29, 2019

alivxxx Jan 29, 2019

XuHuaiyu Jan 28, 2019

lysu Jan 29, 2019

XuHuaiyu Jan 28, 2019

lysu Jan 29, 2019

XuHuaiyu Jan 28, 2019

lysu Jan 29, 2019

eurekaka Jan 29, 2019

lysu Jan 29, 2019

winkyao left a comment

jackysp left a comment

infoschema: add table_id to table and add tidb_indexes table. #9183

infoschema: add table_id to table and add tidb_indexes table. #9183

Conversation

lysu commented Jan 25, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

lysu commented Jan 25, 2019

crazycs520 left a comment

Choose a reason for hiding this comment

codecov-io commented Jan 27, 2019 • edited Loading

Codecov Report

jackysp commented Jan 28, 2019

alivxxx Jan 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

winkyao left a comment

Choose a reason for hiding this comment

jackysp left a comment

Choose a reason for hiding this comment

lysu commented Jan 25, 2019 •

edited

Loading

codecov-io commented Jan 27, 2019 •

edited

Loading

alivxxx Jan 28, 2019 •

edited

Loading