-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: enable function any_value
in aggregation if ONLY_FULL_GROUP_BY
is set
#9255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #9255 +/- ##
==========================================
- Coverage 67.23% 67.23% -0.01%
==========================================
Files 371 371
Lines 77142 77149 +7
==========================================
+ Hits 51869 51872 +3
- Misses 20642 20647 +5
+ Partials 4631 4630 -1
Continue to review full report at Codecov.
|
What problem does this PR solve?
Fix issue #8161
any_value
can be used in aggregation even ifONLY_FULL_GROUP_BY
is set. see MySQL Referernce.What is changed and how it works?
Take special care of
any_value
when validate aggregations inlogical_plan_builder.go
.Check List
Tests
Code changes
Side effects
Related changes