-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, expression: support builtin function NAME_CONST
#9261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9261 +/- ##
==========================================
- Coverage 67.14% 67.13% -0.02%
==========================================
Files 372 372
Lines 77656 77747 +91
==========================================
+ Hits 52146 52193 +47
- Misses 20844 20886 +42
- Partials 4666 4668 +2
Continue to review full report at Codecov.
|
…into support_name_const
LGTM |
@eurekaka PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-common-test |
What problem does this PR solve?
Support builtin function NAME_CONST, part as issue #8439
What is changed and how it works?
NAME_CONST
inexpression/builtin_miscellaneous.go
.When used to produce a result set column, NAME_CONST() causes the column to have the given name
.NAME_CONST
is actually a const, so I add an extraconstant-folding
rule for it.Check List
Tests
Code changes
Side effects
Related changes