-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control the number of rows in chunks returned by SelectResult #9293
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9293 +/- ##
==========================================
+ Coverage 67.15% 67.17% +0.02%
==========================================
Files 371 371
Lines 77496 77505 +9
==========================================
+ Hits 52044 52066 +22
+ Misses 20799 20787 -12
+ Partials 4653 4652 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
18a1d95
to
ed45f2e
Compare
/run-all-tests |
All checks have paased, PTAL~ @lysu |
What problem does this PR solve?
Control the number of rows in chunks returned by
SelectResult
.This PR is a subtask of #9166.
What is changed and how it works?
requiredRows
intoChunk
to specify how many rows the parent executor want.IsFull()
intoChunk
to judge if chunks are considered full by takingrequiredRows
into account.selectResult
andstreamResult
to support this feature.Check List
Tests
Code changes