sessionctx/variable: set log bin #9310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangwenmai
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9310 +/- ##
================================================
- Coverage 67.2278% 67.1801% -0.0477%
================================================
Files 381 381
Lines 79839 79906 +67
================================================
+ Hits 53674 53681 +7
- Misses 21379 21434 +55
- Partials 4786 4791 +5 |
|
I have a request for MySQL compatibility:
|
zz-jason
added
contribution
yangwenmai
force-pushed
the
set_log_bin
branch
2 times, most recently
from
67f6b2b
to
cbd406a
Compare
yangwenmai
changed the title
yangwenmai
changed the title
|
@WangXiangUSTC PTAL |
yangwenmai
changed the title
yangwenmai
force-pushed
the
set_log_bin
branch
from
cbd406a
to
963090c
Compare
yangwenmai
force-pushed
the
set_log_bin
branch
2 times, most recently
from
87c0703
to
f8d2571
Compare
yangwenmai
force-pushed
the
set_log_bin
branch
3 times, most recently
from
e45e389
to
1a8b49d
Compare
|
@WangXiangUSTC PTAL |
|
@WangXiangUSTC PTAL |
sessionctx/binloginfo/binloginfo.go
Outdated
| } | ||
| SetPumpsClient(client) | ||
| } | ||
| pumpsClientLock.RUnlock() |
| } else { | ||
| var err error | ||
| client, err = CreatePumpsClient() | ||
| if err != nil { |
There was a problem hiding this comment.
need unlock before return
sessionctx/binloginfo/binloginfo.go
Outdated
| var binlogCli *pumpcli.PumpsClient | ||
| var err error | ||
| if ShouldEnableBinlog() { | ||
| atomic.StoreUint32(&variable.ProcessGeneralLog, 1) |
There was a problem hiding this comment.
why change this variable?
yangwenmai
force-pushed
the
set_log_bin
branch
2 times, most recently
from
41b30e4
to
d8439ea
Compare
|
@yangwenmai don't need support set log_bin now, I will close this pr. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
impl #9201
Check List
Tests
Code changes