Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add current DB name to the general log #9332

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 17, 2019

What problem does this PR solve?

Add current DB name to the general log.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Enable the general log and test a SQL.
2019/02/17 10:29:51.584 session.go:1644: [info] [GENERAL_LOG] con:2 user:root@127.0.0.1 schema_ver:28 txn_start_ts:0 current_db:test, sql:show tables

Related changes

  • Need to cherry-pick to the release branch

@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Feb 17, 2019
@jackysp jackysp requested review from lysu and crazycs520 February 17, 2019 02:47
@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #9332 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9332      +/-   ##
==========================================
- Coverage    67.2%   67.19%   -0.01%     
==========================================
  Files         371      371              
  Lines       77571    77572       +1     
==========================================
- Hits        52131    52126       -5     
- Misses      20783    20788       +5     
- Partials     4657     4658       +1
Impacted Files Coverage Δ
session/session.go 72.63% <0%> (-0.08%) ⬇️
util/systimemon/systime_mon.go 80% <0%> (-20%) ⬇️
infoschema/infoschema.go 76.31% <0%> (-1.32%) ⬇️
executor/join.go 78.38% <0%> (-0.53%) ⬇️
executor/executor.go 67.03% <0%> (+0.13%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a961d...61f4db0. Read the comment docs.

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 18, 2019
@lysu
Copy link
Contributor

lysu commented Feb 18, 2019

/run-all-tests

@zz-jason zz-jason merged commit 3e78ebc into pingcap:master Feb 18, 2019
jackysp added a commit to jackysp/tidb that referenced this pull request Feb 18, 2019
@jackysp jackysp deleted the add_db branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants