-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: refactor builtin function RAND to be compatible with MySQL #9387
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make a copy for each parallel Project
worker?
Codecov Report
@@ Coverage Diff @@
## master #9387 +/- ##
==========================================
+ Coverage 67.17% 67.17% +<.01%
==========================================
Files 373 373
Lines 78292 78298 +6
==========================================
+ Hits 52590 52599 +9
+ Misses 20992 20987 -5
- Partials 4710 4712 +2
Continue to review full report at Codecov.
|
@zz-jason |
2. Add a Clone func for EvaluatorSuite
a9766ae
to
d31f249
Compare
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
@XuHuaiyu Please cherry pick this commit to release 2.1 and release 2.0 |
What problem does this PR solve?
What is changed and how it works?
getFunction
:If so, return
builtinRandSig
rather thanbuiltinRandWithSeedSig
;If not, evaluate seed each time Rand invoked.
Check List
Tests
integration tests
Code changes
Side effects
N/A
Related changes