-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: change sort to parallel #9418
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9418 +/- ##
==========================================
+ Coverage 67.42% 67.45% +0.03%
==========================================
Files 373 374 +1
Lines 78564 78719 +155
==========================================
+ Hits 52968 53097 +129
- Misses 20839 20858 +19
- Partials 4757 4764 +7
Continue to review full report at Codecov.
|
@@ -759,6 +760,9 @@ type Concurrency struct { | |||
|
|||
// IndexSerialScanConcurrency is the number of concurrent index serial scan worker. | |||
IndexSerialScanConcurrency int | |||
|
|||
//MergeSort is the number of concurrent sort worker | |||
MergeSortConcurrency int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a definition for this in sessionctx/variable/sysvar.go
0f169a5
to
8144e5d
Compare
@yu34po Sorry for the late review, please update to the master branch and resolve conflicts. |
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
closed due to outdated, fell free to reopen it if it's needed. |
What problem does this PR solve?
What is changed and how it works?
make sort executor to parallel process
how it works:
1.get all rows from children executor
2.start several sort worker goroutine, average split rows to every sort worker, for every sort worker sort rows of itself
3.merge the sorted rows from every sort worker
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository